Skip to content

feat(work): bind queue refill CLI to protected owner input (#1017) - #1192

Merged
oxa-orchestrator[bot] merged 40 commits into
mainfrom
agent/1017-refill-cli
Nov 17, 2026
Merged

oxa-orchestrator[bot] merged 40 commits into
mainfrom
agent/1017-refill-cli

Conversation

@n0rpan

@n0rpan n0rpan commented Nov 17, 2026 •

Copy link
Copy Markdown
Collaborator

Feature A — native board (#1214/#1017), T3. Ports #307 row night-watch + feeder + goal-loop → board: assignment/leases, with startup acceptance for restore-lanes / boot units → lead: services. Complete diff: 417 additions and three deletions across five files. The bounded verified repair is allowed by standing O417; no approval or merge waiver.

Adds explicit oxa work board --refill --repo OWNER/REPO --once --token-stdin --config PATH, reusing Consumer, Source, Claims, publisher and the checked private-file reader. The owner-selected manifest and prepared packets live under the protected agent directory outside the source project. They supply the authenticated Worker, partition and existing queue/Claims paths. Project settings, labels and packet text grant no authority.

Default-off and persistent pause return before acquisition, token consumption or publication; offline refuses. A private stdin token is mandatory, with no inherited-token fallback. Task iN/cN identity, branch/base and frozen revision/action must match before reservation. All selected state paths reuse the existing protected_storage guard with the validated Git common directory, excluding current/sibling task trees and Git metadata. The guard itself is unchanged. Source handles complete metadata, global intake cap and issue freshness/open-PR links; audit uses the existing private log. No worker/model/service starts or GitHub mutation occur.

Removes: the former separate Input/Prepared implementation, extracted once in merged #1200, and the weaker current-root-only state-path check. Source history, queues, holds, attempts and regression controls remain.

CI only. Real-binary before controls reproduced outside-protected config acceptance (bb76c0d / 44164797076) and wrong task ref acceptance (767c73a / 44169381704), both exit 0 vs 2. Verified finding discussion_r4606734436 was reproduced by f30daa9 / 44192305086 at work_refill_cli.rs:210: worker-writable queue accepted, ARM 1/1282 failure. Fixed 7745887 passed lane 44193734601 on x86_64+aarch64, including the unchanged queue/claims/pause/log loop, and draft checks 44193745273. The finding is resolved with evidence in discussion_r4606945840. No local builds/tests.

Current exact head f75653c resolves a primary- and author-verified real conflict with main under O420. Main's complete runner/control flow is retained; the work_cmd diff is only guard visibility and the validated common argument. Own diff remains exactly 417+/3-. The normal merge message names #1192 and included #1201. Exact-current selected lane 44200122095 passed on x86_64 and aarch64, and full required checks 44200131892 passed including mandatory-bwrap partitions and inventory guard; earlier results are historical. Fresh code/security review, any applicable owner read and normal merge-queue validation remain required.

This frontend does not complete live #307 acceptance. Receipt wiring/real-CLI qualification is dependent #1223, Core binding is #1220 and Lead407 exclusively owns native execution/whole-job completion with original-lease release. Runtime import/partition reconciliation, same-window comparison and owner qualification remain prerequisites. Helpers stay paused; publication/activation remain off until the composed CLI is qualified.

oxa-agent Bot and others added 27 commits November 17, 2026 19:53
Resolve the work_shadow.rs conflict by keeping both sides: the bounded
detail-batch fixture and its HTTP failure tests from #1153, and main's
descendant-held pipe deadline test. The shared gh stub keeps both the
held-pipe block and the --include response header.

Refs: #1153
@oxa-agent
oxa-agent Bot marked this pull request as ready for review November 17, 2026 22:22
@n0rpan

n0rpan commented Nov 17, 2026

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-17T23:35:07.455472Z f75653c Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: de8cc14f6c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread oxa/oxa-cli/src/work_board/refill.rs Resolved
@oxa-agent
oxa-agent Bot marked this pull request as draft November 17, 2026 22:40
@oxa-agent
oxa-agent Bot marked this pull request as ready for review November 17, 2026 23:18
@n0rpan

n0rpan commented Nov 17, 2026

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Nice work!

Reviewed commit: f75653c3a5

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@oxa-orchestrator
oxa-orchestrator Bot added this pull request to the merge queue Nov 17, 2026
Merged via the queue into main with commit 7f64bcf Nov 17, 2026
31 checks passed
@oxa-orchestrator
oxa-orchestrator Bot deleted the agent/1017-refill-cli branch November 17, 2026 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant